This repository has been archived by the owner on Jun 9, 2021. It is now read-only.
Add a stub typeclass dictionary for the Field instance for Z n
#75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhuffman
suggested changes
Oct 7, 2020
There was a problem hiding this comment.
As a regression test, you should add the same definition to cryptol-saw-core/test/instance.cry that you added in GaloisInc/cryptol@2d2e2b9. Also, when you do, please note in the commit message that this is related to GaloisInc/cryptol#882; in the absence of a git submodule, notes like this are the only record of which version of cryptol the tests are supposed to work with.
Tracks the changes in Cryptol from GaloisInc/cryptol#882 which adds primality testing to the Cryptol type system, and implements field operations for `Z p`. Currently, we don't represent the primality test in SAWCore, but we might revisit this aspect in the future.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.